test_runner: refactor primordial-based Promise chains #55958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Nov 22, 2024
aduh95
reviewed
Nov 22, 2024
aduh95
reviewed
Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55958 +/- ##
=======================================
Coverage 87.99% 88.00%
=======================================
Files 653 653
Lines 188091 188090 -1
Branches 35941 35943 +2
=======================================
+ Hits 165516 165523 +7
+ Misses 15751 15734 -17
- Partials 6824 6833 +9
|
benjamingr
approved these changes
Nov 23, 2024
pmarchini
approved these changes
Nov 23, 2024
JakobJingleheimer
approved these changes
Nov 23, 2024
jasnell
approved these changes
Nov 23, 2024
atlowChemi
approved these changes
Nov 23, 2024
This commit refactors the buildSuite Promise logic in the Suite constructor to use an async function instead of creating an awkward primordial-based Promise chain.
This commit refactors the chain of functions in run() to use an async function instead of creating an awkward primordial-based Promise chain.
cjihrig
added
commit-queue-rebase
github-actions
bot
removed
the
request-ci
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/55958 ✔ Done loading data for nodejs/node/pull/55958 ----------------------------------- PR info ------------------------------------ Title test_runner: refactor primordial-based Promise chains (#55958) Author Colin Ihrig <[email protected]> (@cjihrig) Branch cjihrig:promises -> nodejs:main Labels commit-queue-rebase, test_runner Commits 2 - test_runner: refactor build Promise in Suite() - test_runner: refactor Promise chain in run() Committers 1 - cjihrig <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: refactor build Promise in Suite() ⚠ - test_runner: refactor Promise chain in run() ℹ This PR was created on Fri, 22 Nov 2024 21:02:13 GMT ✔ Approvals: 7 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2455645777 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456378535 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456381657 ✔ - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456382466 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456411715 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456425980 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55958#pullrequestreview-2456475030 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-25T00:15:13Z: https://ci.nodejs.org/job/node-test-pull-request/63691/ - Querying data for job/node-test-pull-request/63691/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12002350325 |
nodejs-github-bot
added
the
commit-queue-failed
pmarchini
approved these changes
Nov 25, 2024
pmarchini
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c9bf257...3c35188 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
This commit refactors the buildSuite Promise logic in the Suite constructor to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: #55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
This commit refactors the chain of functions in run() to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: #55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
This commit refactors the buildSuite Promise logic in the Suite constructor to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: nodejs#55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
This commit refactors the chain of functions in run() to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: nodejs#55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
This commit refactors the buildSuite Promise logic in the Suite constructor to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: #55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
This commit refactors the chain of functions in run() to use an async function instead of creating an awkward primordial-based Promise chain. PR-URL: #55958 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors two Promise chains in the test runner to use async/await style syntax instead. IMO this makes these two pieces of code significantly more readable (largely because of primordials), and will make some planned changes easier to implement.
test_runner: refactor build Promise in Suite()
This commit refactors the buildSuite Promise logic in the Suite
constructor to use an async function instead of creating an
awkward primordial-based Promise chain.
test_runner: refactor Promise chain in run()
This commit refactors the chain of functions in run() to use an
async function instead of creating an awkward primordial-based
Promise chain.